FIX zoom in docs #10801
Merged
FIX zoom in docs #10801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
May 16, 2020
| position: 'relative', | ||
| }); | ||
|
|
||
| const getLayout = (children: ReactElement[]) => { |
There was a problem hiding this comment.
AFAICT this uses the first story layout if there are multiple stories with different layouts, or padded if there are non-story children. WDYT about using the story layout if all children are stories and their layouts match, and padded layout in any other case. Seems a little simpler and more predictable?
|
@ndelangen gadzooks! i'm seeing some regressions in the UI review 🔍 |
…kjs/storybook into tech/cleanup-docs-code-fix-zoom
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did